Upload banner error
- Thread starter andree
- Start date
I understood you correctly? For both file checks it gives the same wrong error message?
Are you on visiolist version 1.6? cause the invalid file check doesnt even happen when there is an error already
Are you on visiolist version 1.6? cause the invalid file check doesnt even happen when there is an error already
Code:
if(empty($errors))
{
$size = getimagesize($_FILES['image']['tmp_name']);
$fp = fopen($_FILES['image']['tmp_name'], "rb");
if ($size && $fp)
{
// All OK
$banner_width = (int)$size[0];
$banner_height = (int)$size[1];
// Plugin Hook - image data
eval (PluginManager::getPluginManager ()->pluginHooks ('usercp_banner_upload_image_data'));
}
else
{
$TMPL['user_cp_upload_errors'] = "<h1 class=\"user_cp_upload_error\">{$LNG['user_cp_banner_invalid_file']}</h1>";
$errors = 1;
}
}
Last edited:
{$lng->user_cp_banner_error_max_dimensions}englishYou have exceeded the maximum dimensions!
{$lng->user_cp_banner_error_max_filesize}englishYou have exceeded the size limit!
{$lng->user_cp_banner_unknown_extension}englishUnknown extension!
If i click upload with no image selected then gives error Unknown extension!
{$lng->user_cp_banner_error_max_filesize}englishYou have exceeded the size limit!
{$lng->user_cp_banner_unknown_extension}englishUnknown extension!
If i click upload with no image selected then gives error Unknown extension!
HTML:
//===========================================================================\\
// VISIOLIST is a proud derivative work of Aardvark Topsites \\
// Copyright (c) 2000-2009 Jeremy Scheff. All rights reserved. \\
//---------------------------------------------------------------------------\\
// http://www.aardvarktopsitesphp.com/ http://www.avatic.com/ \\
//---------------------------------------------------------------------------\\
// This program is free software; you can redistribute it and/or modify it \\
// under the terms of the GNU General Public License as published by the \\
// Free Software Foundation; either version 2 of the License, or (at your \\
// option) any later version. \\
// \\
// This program is distributed in the hope that it will be useful, but \\
// WITHOUT ANY WARRANTY; without even the implied warranty of \\
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General \\
// Public License for more details. \\
//===========================================================================\\
if (!defined('VISIOLIST')) {
die("This file cannot be accessed directly.");
}
//error_reporting(0);
class banner extends base {
public function __construct() {
global $CONF, $FORM, $LNG, $DB, $TMPL;
$upload_mode = 1;
if(isset($FORM['mode']) && is_numeric($FORM['mode'])) {
$upload_mode = intval($FORM['mode']);
}
// With this we allow users to upload to a different location
$banner_folder = 'banners';
switch ($upload_mode) {
case "3":
$TMPL['user_cp_upload_max_size'] = 200; //Premium Banner
$TMPL['user_cp_upload_max_width'] = $CONF['max_premium_banner_width'];
$TMPL['user_cp_upload_max_height'] = $CONF['max_premium_banner_height'];
$bannertype = $LNG['premium'];
break;
case "1":
default:
$TMPL['user_cp_upload_max_size'] = 100; //Regular Banner
$TMPL['user_cp_upload_max_width'] = $CONF['max_banner_width'];
$TMPL['user_cp_upload_max_height'] = $CONF['max_banner_height'];
$bannertype = $LNG['user_cp_banner_regular'];
break;
}
$TMPL['header'] = $LNG['user_cp_banner_upload_your'].' '.$bannertype;
//GET OWNER AND SITE LIST
$result = $DB->query("SELECT owner FROM {$CONF['sql_prefix']}_sites WHERE username = '{$TMPL['username']}'", __FILE__, __LINE__);
while (list($myowner) = $DB->fetch_array($result))
{
$TMPL['myowner'] = $myowner;
}
$row = $DB->fetch("SELECT * FROM {$CONF['sql_prefix']}_sites WHERE username = '{$TMPL['username']}'", __FILE__, __LINE__);
$row = array_map(function($value) {
return htmlspecialchars($value, ENT_QUOTES, "UTF-8");
}, $row);
$TMPL = array_merge($TMPL, $row);
eval (PluginManager::getPluginManager ()->pluginHooks ('usercp_banner_upload_start'));
if($upload_mode == 3)
{
// Premium mode
$result = $DB->query("SELECT username, url FROM {$CONF['sql_prefix']}_sites WHERE owner = '{$TMPL['myowner']}' AND (active = 1 OR active = 3) AND premium_flag > 0", __FILE__, __LINE__);
eval (PluginManager::getPluginManager ()->pluginHooks ('usercp_banner_extend_upload_mode_premium'));
}
else
{
// Whatever form "mode" is else, use normal mode
$result = $DB->query("SELECT username, url FROM {$CONF['sql_prefix']}_sites WHERE owner = '{$TMPL['myowner']}' AND (active = 1 OR active = 3)", __FILE__, __LINE__);
eval (PluginManager::getPluginManager ()->pluginHooks ('usercp_banner_extend_upload_mode_regular'));
}
$TMPL['user_cp_upload_sites'] = '';
$i = 0;
while (list($sitelist, $sitelist_url) = $DB->fetch_array($result))
{
$i++;
$TMPL['user_cp_upload_sites'] .= '<option value="'.$sitelist.'">'.$sitelist_url.'</option>';
}
// Stop here if while loop is empty
if(empty($i))
{
header("Location: {$TMPL['list_url']}/index.php?a=user_cpl&b=user_premium");
exit;
}
// On submit
if(isset($FORM['submit']))
{
$TMPL['myusername'] = isset($FORM['site']) ? $FORM['site'] : '';
$errors = 0;
if (isset($_FILES['image']['name']))
{
$filename = stripslashes($_FILES['image']['name']);
$extension = $this->getExtension($filename);
$extension = strtolower($extension);
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif"))
{
$TMPL['user_cp_upload_errors'] = "<h1 class=\"user_cp_upload_error\">{$LNG['user_cp_banner_unknown_extension']}</h1>";
$errors = 1;
}
else
{
//File size check
$size = $this->get_file_size($_FILES['image']['tmp_name']);
if ($size > $TMPL['user_cp_upload_max_size'] * 1024)
{
$TMPL['user_cp_upload_errors'] = "<h1 class=\"user_cp_upload_error\">{$LNG['user_cp_banner_error_max_filesize']}</h1>";
$errors = 1;
}
//Check Dimensions
if($CONF['max_banner_height'] > 0 && empty($errors))
{
list($width, $height, $type, $attr) = getimagesize("{$_FILES['image']['tmp_name']}");
if ($width > $TMPL['user_cp_upload_max_width'] || $height > $TMPL['user_cp_upload_max_height'])
{
$TMPL['user_cp_upload_errors'] = "<h1 class=\"user_cp_upload_error\">{$LNG['user_cp_banner_error_max_dimensions']}</h1>";
$errors = 1;
}
}
//Check MIME
if(empty($errors))
{
$size = getimagesize($_FILES['image']['tmp_name']);
$fp = fopen($_FILES['image']['tmp_name'], "rb");
if ($size && $fp)
{
// All OK
$banner_width = (int)$size[0];
$banner_height = (int)$size[1];
// Plugin Hook - image data
eval (PluginManager::getPluginManager ()->pluginHooks ('usercp_banner_upload_image_data'));
}
else
{
$TMPL['user_cp_upload_errors'] = "<h1 class=\"user_cp_upload_error\">{$LNG['user_cp_banner_invalid_file']}</h1>";
$errors = 1;
}
}
// Check for correct username. Some may alter select options to fuck up other members
if(empty($errors))
{
$result = $DB->query("SELECT owner FROM {$CONF['sql_prefix']}_sites WHERE username = '{$TMPL['myusername']}'", __FILE__, __LINE__);
while (list($myowner_check) = $DB->fetch_array($result))
{
$TMPL['myowner_check'] = $myowner_check;
}
if($TMPL['myowner_check'] != $TMPL['myowner'])
{
exit;
}
}
// The image time to bust cache
$image_time = time() + (3600 * $CONF['time_offset']);
if($upload_mode == 3)
{
$newname = "{$banner_folder}/{$TMPL['myusername']}_premium_{$image_time}.{$extension}";
}
else
{
$newname = "{$banner_folder}/{$TMPL['myusername']}_{$image_time}.{$extension}";
}
// move image to upload path
if(empty($errors))
{
if (!move_uploaded_file($_FILES['image']['tmp_name'], "{$CONF['path']}/{$newname}"))
{
$TMPL['user_cp_upload_errors'] = "<h1 class=\"user_cp_upload_error\">{$LNG['user_cp_banner_copy_fail']}</h1>";
$errors = 1;
}
}
}
}
else {
$TMPL['user_cp_upload_errors'] = "<h1 class=\"user_cp_upload_error\">{$LNG['user_cp_banner_no_image']}</h1>";
$errors = 1;
}
// If no errors registered, handle old and new banner/mp4
if(empty($errors))
{
$fullnewname = $CONF['list_url'].'/'.$newname;
// Remove old normal/premium banner
if($upload_mode == 3)
{
// Only if not default banner
if (!empty($TMPL['premium_banner_url']) && $TMPL['premium_banner_url'] != $CONF['default_banner'])
{
// Only if local image
if (stripos($TMPL['premium_banner_url'], $CONF['list_url']) === 0)
{
$old_premium_banner = str_replace($CONF['list_url'], $CONF['path'], $TMPL['premium_banner_url']);
if (file_exists($old_premium_banner)) {
unlink($old_premium_banner);
}
}
}
$DB->query("UPDATE {$CONF['sql_prefix']}_sites SET premium_banner_url = '{$fullnewname}', premium_banner_width = {$banner_width}, premium_banner_height = {$banner_height} WHERE username = '{$TMPL['myusername']}'", __FILE__, __LINE__);
}
else
{
// Only if not default banner
if (!empty($TMPL['banner_url']) && $TMPL['banner_url'] != $CONF['default_banner'])
{
// Only if local image
if (stripos($TMPL['banner_url'], $CONF['list_url']) === 0)
{
$old_banner = str_replace($CONF['list_url'], $CONF['path'], $TMPL['banner_url']);
if (file_exists($old_banner)) {
unlink($old_banner);
}
}
}
$DB->query("UPDATE {$CONF['sql_prefix']}_sites SET banner_url = '{$fullnewname}', banner_width = {$banner_width}, banner_height = {$banner_height} WHERE username = '{$TMPL['myusername']}'", __FILE__, __LINE__);
}
$TMPL['user_cp_upload_success'] = "<h1>{$LNG['user_cp_banner_success']}</h1> <p><img src=\"{$fullnewname}\" width=\"{$banner_width}\" height=\"{$banner_height}\" /></p>";
// final filesize
$finalsize = $this->formatBytes($this->get_file_size($newname, true));
$allowedfilesize = $this->formatBytes($TMPL['user_cp_upload_max_size'] * 1024);
$TMPL['user_cp_upload_filesize'] = "<h2>{$LNG['user_cp_banner_file_size']}: {$finalsize} / {$allowedfilesize}</h2>";
// gif to mp4 conversion using ffmpeg for smaller filesizes
if (function_exists('shell_exec'))
{
// Force a file path search using "type".
// "which" may be empty if you not modified $PATH
// Returns filepath for ffmpeg, just some safecheck since ffmpeg alone may not always work on every system
$ffmpeg_path = trim(shell_exec('type -P ffmpeg'));
if (!empty($ffmpeg_path))
{
// Remove old normal/premium mp4
if($upload_mode == 3)
{
// Only if not default mp4
if (!empty($TMPL['premium_mp4_url']) && $TMPL['premium_mp4_url'] != $CONF['default_banner_mp4'])
{
// Only if local mp4
if (stripos($TMPL['premium_mp4_url'], $CONF['list_url']) === 0)
{
$old_premium_mp4 = str_replace($CONF['list_url'], $CONF['path'], $TMPL['premium_mp4_url']);
if (file_exists($old_premium_mp4)) {
unlink($old_premium_mp4);
}
}
}
}
else
{
// Only if not default mp4
if (!empty($TMPL['mp4_url']) && $TMPL['mp4_url'] != $CONF['default_banner_mp4'])
{
// Only if local mp4
if (stripos($TMPL['mp4_url'], $CONF['list_url']) === 0)
{
$old_mp4 = str_replace($CONF['list_url'], $CONF['path'], $TMPL['mp4_url']);
if (file_exists($old_mp4)) {
unlink($old_mp4);
}
}
}
}
// We can convert gif. Png aint possible due transparency, jpg possible but many color jpg's get blurry due mp4 max 258 colors or so
if ($extension == 'gif')
{
// Get the filename without extension
// Based on $upload_mode, $newname can be different names
$ffmpeg_image = basename($newname, ".{$extension}");
// mp4 url
$ffmpeg_mp4_url = $DB->escape("{$CONF['list_url']}/{$banner_folder}/mp4/{$ffmpeg_image}.mp4", 1);
// actual convert command
// (-y) - Disable confirm promts when overwriting files
// (-movflags faststart) - Make video playable and load quicker under html5
// (-pix_fmt yuv420p) - Set pixel format. H.264 video is safe across browsers. If not available -pix_fmt auto picks best value for encoder in use
// (-preset veryslow) - Longer convert time, but better compression
// (-vf 'scale=trunc(iw/2)*2:trunc(ih/2)*2') - MP4 videos using H.264 need to have a dimensions that is divisible by 2. This option ensures that's the case for the filtergraph frame conversion
// (</dev/null >/dev/null 2>&1) - Redirect stdin/stdout/stderr into nothingness and make it a background process
shell_exec("{$ffmpeg_path} -y -i \"{$CONF['path']}/{$banner_folder}/{$ffmpeg_image}.{$extension}\" -movflags faststart -pix_fmt yuv420p -preset veryslow -vf 'scale=trunc(iw/2)*2:trunc(ih/2)*2' \"{$CONF['path']}/{$banner_folder}/mp4/{$ffmpeg_image}.mp4\" </dev/null >/dev/null 2>&1");
// Store mp4 url
if($upload_mode == 3)
{
$DB->query("UPDATE {$CONF['sql_prefix']}_sites SET premium_mp4_url = '{$ffmpeg_mp4_url}' WHERE username = '{$TMPL['myusername']}'", __FILE__, __LINE__);
}
else
{
$DB->query("UPDATE {$CONF['sql_prefix']}_sites SET mp4_url = '{$ffmpeg_mp4_url}' WHERE username = '{$TMPL['myusername']}'", __FILE__, __LINE__);
}
}
else
{
// Reset mp4 column for png /jpg
if($upload_mode == 3)
{
$DB->query("UPDATE {$CONF['sql_prefix']}_sites SET premium_mp4_url = NULL WHERE username = '{$TMPL['myusername']}'", __FILE__, __LINE__);
}
else
{
$DB->query("UPDATE {$CONF['sql_prefix']}_sites SET mp4_url = NULL WHERE username = '{$TMPL['myusername']}'", __FILE__, __LINE__);
}
}
}
}
// Plugin Hook - extend update query or set new tmpl vars
eval (PluginManager::getPluginManager ()->pluginHooks ('usercp_banner_upload_finish'));
}
}
$TMPL['user_cp_content'] = $this->do_skin('user_cp_upload_banner');
}
function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$ext = substr($str,$i+1,$l);
return $ext;
}
}Ok please try this, i included all possible errors which php itself might include on an fileupload
Your issue was most likely "The uploaded file exceeds the upload_max_filesize directive in php.ini". You probably have that lower than your your file you wanna upload
For anyone who want to do this, this is ONLY for visiolist 1.6!
open sources/misc/classes.php and find
- This is for now just hardcoded english language and will be updated with vl 1.7
On a new line before, add this function
Now download the attached zip und unzip it. the file banner.php you upload to sources/user_cp/ replacing the old file
Your issue was most likely "The uploaded file exceeds the upload_max_filesize directive in php.ini". You probably have that lower than your your file you wanna upload
For anyone who want to do this, this is ONLY for visiolist 1.6!
open sources/misc/classes.php and find
- This is for now just hardcoded english language and will be updated with vl 1.7
Code:
public function get_file_size($file_path, $clear_stat_cache = false) {
Code:
public function get_file_error($error_code) {
global $LNG;
$errors = [
1 => 'The uploaded file exceeds the upload_max_filesize directive in php.ini',
2 => 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form',
3 => 'The uploaded file was only partially uploaded',
4 => $LNG['user_cp_banner_no_image'],
6 => 'Missing a temporary folder',
7 => 'Failed to write file to disk',
8 => 'A PHP extension stopped the file upload',
];
return isset($errors[$error_code]) ? $errors[$error_code] : 'Unknown Error';
}